Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7000#discussion_r33210655
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/HiveTypeCoercion.scala
 ---
    @@ -677,8 +677,8 @@ trait HiveTypeCoercion {
               findTightestCommonTypeAndPromoteToString((c.key +: 
c.whenList).map(_.dataType))
             maybeCommonType.map { commonType =>
               val castedBranches = c.branches.grouped(2).map {
    -            case Seq(when, then) if when.dataType != commonType =>
    -              Seq(Cast(when, commonType), then)
    +            case Seq(whenExpr, thenExpr) if whenExpr.dataType != 
commonType =>
    --- End diff --
    
    Yes - but it doesn't happen that often and is caught by compiler warnings 
-- so not that big of a deal right now. If it is used a lot, we should consider 
having a rule.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to