Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/7014#discussion_r33255869
--- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala
---
@@ -745,8 +745,9 @@ class DAGScheduler(
submitWaitingStages()
}
- private[scheduler] def handleTaskSetFailed(taskSet: TaskSet, reason:
String) {
- stageIdToStage.get(taskSet.stageId).foreach {abortStage(_, reason) }
+ private[scheduler] def handleTaskSetFailed(taskSet: TaskSet, reason:
String,
+ exception: Option[Throwable]
= None) {
+ stageIdToStage.get(taskSet.stageId).foreach {abortStage(_, reason,
exception) }
--- End diff --
nit: multiline method defs should have each arg on a separate line, all
indented 4 extra spaces. Also include the return type (I know it wasn't there
before but as long as you're touching this ...)
```scala
private[scheduler] def handleTaskSetFailed(
taskSet: TaskSet,
reason: String,
exception: Option[Throwable] = None): Unit = {
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
