Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/6827#issuecomment-115313702
So, one thing that I noticed after I said "LGTM" is that this change breaks
old logs (those generated by versions of Spark that do not record the app id).
Those will never show up anymore (I think that should only be Spark 1.0?).
If we care about that use case, this version should probably be reverted.
The proper fix could be something as simple as this:
appListener.appId.getOrElse(logPath.getName().stripSuffix(EventLoggingListener.IN_PROGRESS)),
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
