GitHub user JoshRosen opened a pull request:
https://github.com/apache/spark/pull/7032
[SPARK-8652] [PYSPARK] Check return value for all uses of doctest.testmod()
This patch addresses a critical issue in the PySpark tests:
Several of our Python modules' `__main__` methods call `doctest.testmod()`
in order to run doctests but forget to check and handle its return value. As a
result, some PySpark test failures can go unnoticed because they will not fail
the build.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JoshRosen/spark testmod-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/7032.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7032
----
commit e6423f9bcf6f3eae0c9f5e5cd440f1cae30052c3
Author: Josh Rosen <[email protected]>
Date: 2015-06-26T06:17:13Z
Check return code for all uses of doctest.testmod().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
