Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/772#discussion_r13017555
--- Diff: bin/compute-classpath.sh ---
@@ -56,9 +56,9 @@ if [ -f "$ASSEMBLY_DIR"/spark-assembly*hadoop*-deps.jar
]; then
else
# Else use spark-assembly jar from either RELEASE or assembly directory
if [ -f "$FWDIR/RELEASE" ]; then
- ASSEMBLY_JAR=$(ls "$FWDIR"/lib/spark-assembly*hadoop*.jar 2>/dev/null)
+ ASSEMBLY_JAR=$(ls "$FWDIR"/lib/spark-assembly*.jar 2>/dev/null)
--- End diff --
We should keep the jar naming consistent between the builds. Could we just
add this?
```
jarName in assembly <<= version map { v => "spark-assembly-" + v +
"-hadoop" + hadoopVersion + ".jar" },
```
You might be able to just do `System.getProperty("hadoop.version"))`, or if
there are some ordering issues between this code and `backwardsCompatiblity`,
you could factor this out into a function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
