Github user srowen commented on the pull request:

    https://github.com/apache/spark/pull/7042#issuecomment-115704313
  
    The code you are changing still exists in `master`, on about line 321. You 
would need to propose a change versus `master`; it would still need to be fixed 
there first right? I don't think that commit is actually related to this.
    
    Is the better fix in `ClientDistributedCacheManager.addResource`? I don't 
see why it takes a `FileSystem` there, since it doesn't really make sense 
unless it matches the one used by its `Path` argument. If that can't be done 
for some reason I agree with this change, since I kind of looks like that was 
the intent in 
    
https://github.com/apache/spark/commit/50ab8a6543ad5c31e89c16df374d0cb13222fd1e
    CC @vanzin for a thought


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to