Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/7020#discussion_r33377752
--- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
@@ -56,7 +56,7 @@ object Partitioner {
*/
def defaultPartitioner(rdd: RDD[_], others: RDD[_]*): Partitioner = {
val bySize = (Seq(rdd) ++ others).sortBy(_.partitions.size).reverse
- for (r <- bySize if r.partitioner.isDefined) {
+ for (r <- bySize if r.partitioner.isDefined && r.partitions.nonEmpty) {
return r.partitioner.get
}
--- End diff --
And? Again, if `r.partitioner` is not defined (i.e., is `None`), then the
for comprehension I wrote will not execute the `return`. Only if
`r.partitioner` is `Some(p)` && `r.partitions.nonEmpty` will `return p` be
executed. If those conditions are not true for any `r`, then the for
comprehension won't do anything and execution will fall through.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
