Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5423#issuecomment-115902331
I haven't finished reviewing this, but I need a break... this patch is
huge. It might be worth it to spend some time thinking of a good way to break
it down into smaller pills. :-) e.g. one PR for the write side, one for the
read side, at least.
Overall, I see a lot of small style issues (unneeded brackets, funny
indentation, usage of a few less desired Scala patterns, things like that). It
also seems like there's a lot of public methods that don't seem necessary -
maybe they're used in the tests, but I'm really far from getting to that point
in the code right now.
It also felt a little worrying that it seems like the code completely
ignores attempt IDs (at least in the read side - haven't gotten to the write
side yet).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
