Github user litao-buptsse commented on the pull request:
https://github.com/apache/spark/pull/7053#issuecomment-116045509
@srowen I think maybe the first fs param in addResource() is needed,
especially it's useful when doing unit test. I see the
ClientDistributedCacheManagerSuite usually pass a mock fs to the addResource().
So I think to keep the first fs param might be better, although it's sometimes
redundant.
ClientDistributedCacheManagerSuite unit tests:
https://github.com/apache/spark/blob/master/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientDistributedCacheManagerSuite.scala
My failed unit tests:
https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/967/testReport/org.apache.spark.deploy.yarn/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
