Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6959#discussion_r33418937
  
    --- Diff: 
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeFixedWidthAggregationMap.java
 ---
    @@ -55,9 +67,19 @@
       private final BytesToBytesMap map;
     
       /**
    +   * A object pool for these in keys.
    +   */
    +  private final UniqueObjectPool keyPool;
    +
    +  /**
    +   * A object pool for those in aggregation buffers.
    +   */
    +  private final ObjectPool bufferPool;
    --- End diff --
    
    The type is already `ObjectPool`,  having the full name in the variable 
name is too verbose, I think.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to