Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7064#discussion_r33419075
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAOptimizer.scala ---
    @@ -134,8 +146,10 @@ final class EMLDAOptimizer extends LDAOptimizer {
           verticesTMP.reduceByKey(_ + _)
         }
     
    +    // vertices are non empty docs and empty docs
    +    val docAllTermVertices = docTermVertices union emptyDocTermVertices
    --- End diff --
    
    I'm not 100% sure this is a hard style rule, but best to avoid this syntax 
and write `a.union(b)`. It generates a compiler warning otherwise IIRC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to