Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/860#discussion_r13029354
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -329,8 +329,21 @@ private[spark] class BlockManager(
        * never deletes (recent) items.
        */
       def getLocalFromDisk(blockId: BlockId, serializer: Serializer): 
Option[Iterator[Any]] = {
    -    diskStore.getValues(blockId, serializer).orElse(
    -      sys.error("Block " + blockId + " not found on disk, though it should 
be"))
    +    class LazyProxyIterator(f: => Iterator[Any]) extends Iterator[Any] {
    --- End diff --
    
    Do you mind adding some inline comment on why we are doing this? (basically 
your pull request description)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to