Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6262#discussion_r33477722
  
    --- Diff: python/pyspark/tests.py ---
    @@ -874,6 +874,15 @@ def 
test_sortByKey_uses_all_partitions_not_only_first_and_last(self):
                 for size in sizes:
                     self.assertGreater(size, 0)
     
    +    def test_pipe_functions(self):
    +        data = ['1', '2', '3']
    +        rdd = self.sc.parallelize(data)
    +        with QuietTest(self.sc):
    +            self.assertRaises(Py4JJavaError, rdd.pipe('cc').collect)
    +        result = rdd.pipe('cat').collect()
    --- End diff --
    
    @davies, I guess that your comment about `grep` is due to the fact that the 
fix here might break programs that used to work in case they relied on the old 
behavior? I guess that one option might be to add a configuration flag for 
controlling the exit-code-handling behavior and to update the documentation to 
address this. Any thoughts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to