Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/5423#issuecomment-116761481
> Splitting up the patch? Would that help?
Yes. Reviewing a 9k line patch is a lot of work, regardless of where the
code is. People still need to review test code. If you argue that github
doesn't have a very good way to do multi-PR reviews, I'll agree with you there,
but that's what we have to live with.
> Regarding app attempts ... it's been chasing a moving target.
Actually there was a single change that modified the API to support
attempts. But my main worry is that you're just not handling them at all;
you're probably serving bad information by ignoring attempts, when it would
have been better to raise an error or do some basic filtering instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
