Github user liancheng commented on a diff in the pull request: https://github.com/apache/spark/pull/6796#discussion_r33486716 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/parquet/ParquetTypes.scala --- @@ -43,16 +43,27 @@ private[parquet] object ParquetTypesConverter extends Logging { } /** - * Compute the FIXED_LEN_BYTE_ARRAY length needed to represent a given DECIMAL precision. + * BYTES_FOR_PRECISION computes the required bytes to store a value of a certain decimal + * precision. */ - private[parquet] val BYTES_FOR_PRECISION = Array.tabulate[Int](38) { precision => - var length = 1 + private[parquet] def BYTES_FOR_PRECISION_COMPUTE(precision : Int) : Int = { --- End diff -- Prefer `bytesForPrecision` since it's a method instead of a constant.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org