Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7026#discussion_r33498326
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/VersionsSuite.scala ---
@@ -170,5 +180,12 @@ class VersionsSuite extends SparkFunSuite with Logging
{
false,
false)
}
+
+ test(s"$version: create index and reset") {
+ client.runSqlHive("CREATE TABLE indexed_table (key INT)")
+ client.runSqlHive("CREATE INDEX index_1 ON TABLE indexed_table(key)
" +
+ "as 'COMPACT' WITH DEFERRED REBUILD")
+ client.reset()
+ }
--- End diff --
Some of the other tests do verify the results (i.e. create a table and then
make sure its in the list of tables) and in general I'm skeptical of the
argument that just because existing tests are great, new ones also shouldn't
be. That said, we can merge this and I can improve the tests in a followup.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
