Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7066#discussion_r33500485
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -92,6 +92,16 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
           }, 0, reviveIntervalMs, TimeUnit.MILLISECONDS)
         }
     
    +    private def getSparkConfProperties(): Seq[(String, String)] = {
    +      val properties = new ArrayBuffer[(String, String)]
    +      for ((key, value) <- sparkConf.getAll) {
    +        if (key.startsWith("spark.")) {
    +          properties += ((key, value))
    +        }
    +      }
    +      properties
    +    }
    --- End diff --
    
    after you move it, I would add a comment that says:
    ```
    // Retrieve fresh properties from SparkConf again in case a new property is 
set
    // This is necessary for passing certain properties to executors in YARN 
(SPARK-8687)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to