Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/7080#discussion_r33505552
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala
---
@@ -208,8 +208,11 @@ class LogisticRegressionSuite extends SparkFunSuite
with MLlibTestSparkContext {
}
test("binary logistic regression with intercept without regularization")
{
- val trainer = (new LogisticRegression).setFitIntercept(true)
- val model = trainer.fit(binaryDataset)
+ val trainer1 = (new LogisticRegression).setFitIntercept(true)
--- End diff --
For consistency with how the tests for setFitIntercept were done, maybe
have setStandardization(true) here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
