Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/7070#issuecomment-116882483
Thanks for contributing this! This feature looks good, but still requires
some more polishing:
1. Please fix the style issues as I commented.
1. Please add this configuration to `SQLConf`. Example:
- [`SQLConf.PARQUET_FILTER_PUSHDOWN_ENABLED`] [1]
- [`SQLConf.parquetFilterPushDown`] [2]
1. Please add a test case for this.
For example, we can write two Parquet files with incompatible schemas
and put them into the same directory, then read the directory to see whether
the schema merging is triggered (if it's triggered, exception will be thrown
due to incompatible schemas).
[1]:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala#L255-L261
[2]:
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala#L434
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
