Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/7097#discussion_r33537399
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -529,10 +537,34 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
}
}
+ /**
+ * Returns whether the version of Spark that generated logs records app
IDs. App IDs were added
+ * in Spark 1.1.
+ */
+ private def sparkVersionHasAppId(entry: FileStatus): Boolean = {
+ if (isLegacyLogDirectory(entry)) {
+ fs.listStatus(entry.getPath())
+ .find { status =>
status.getPath().getName().startsWith(SPARK_VERSION_PREFIX) }
+ .map { status =>
+ val version =
status.getPath().getName().substring(SPARK_VERSION_PREFIX.length())
+ version != "1.0" && version != "1.1"
--- End diff --
why do we check for 1.1 here if app IDs are already added then? Were they
missing in some but not all of the 1.1.x releases?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
