Github user tarekauel commented on the pull request:
https://github.com/apache/spark/pull/6981#issuecomment-116967031
@davies I improved the implementation.
The time functions create still a `Date`object, as part of `getOffSet`. But
It's necessary to convert the time, in order to get the correct result for
`Minute` and `Hour`. It isn't necessary for `Seconds` but I guess it's simpler,
if it's implemented the same way.
The range for the fallback is two days big. This allows to ignore the time
difference.
`Day` and `WeekOfYear` uses always `Calendar`.
In order to try to guarantee the functionality, I added some more tests.
@rxin I am going to close it for now, please keep me in the loop. You can
assign the Jira tickets to me, if it helps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
