Github user XuTingjun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6950#discussion_r33543095
  
    --- Diff: core/src/main/scala/org/apache/spark/ui/exec/ExecutorsTab.scala 
---
    @@ -92,15 +92,18 @@ class ExecutorsListener(storageStatusListener: 
StorageStatusListener) extends Sp
         val info = taskEnd.taskInfo
         if (info != null) {
           val eid = info.executorId
    -      executorToTasksActive(eid) = executorToTasksActive.getOrElse(eid, 1) 
- 1
    -      executorToDuration(eid) = executorToDuration.getOrElse(eid, 0L) + 
info.duration
           taskEnd.reason match {
    +        case Resubmitted =>
    +          return
    --- End diff --
    
    I think so, because these ```Resubmitted SparkListenerTaskEnd``` tasks have 
post a ```Success SparkListenerTaskEnd``` before, all the metrics have been 
updated. If update here, the metrics will calculate twice.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to