Github user vinodkc commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7015#discussion_r33558094
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/AbstractSparkSQLParser.scala
 ---
    @@ -30,12 +30,14 @@ private[sql] abstract class AbstractSparkSQLParser
     
       def parse(input: String): LogicalPlan = {
         // Initialize the Keywords.
    -    lexical.initialize(reservedWords)
    +    initLexical
         phrase(start)(new lexical.Scanner(input)) match {
           case Success(plan, _) => plan
           case failureOrError => sys.error(failureOrError.toString)
         }
       }
    +  /* One time initialization of lexical.This avoid reinitialization of  
lexical in parse method */
    +  protected lazy val initLexical: Unit = lexical.initialize(reservedWords)
    --- End diff --
    
     'reservedWords' is generated using reflection. So during non-lazy 
'lexical' initialization in constructor, method call to collect  reservedWords 
will fail as the object construction is still not over.
    Coud you suggest any other approach?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to