Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6762#discussion_r33655087
  
    --- Diff: 
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -159,6 +162,77 @@ public UTF8String toLowerCase() {
         return UTF8String.fromString(toString().toLowerCase());
       }
     
    +  public UTF8String trim() {
    +    return UTF8String.fromString(toString().trim());
    --- End diff --
    
    I am not sure if the if we can operate the bytes for UTF8, particularly for 
the suffix bytes for `trim` or `rightTrim`. as it may occurpt the string. 
    For example, in UTF-8, a Chinese character is 3 bytes, and the last byte 
probably be 0x20 (space), however, we can simply cut off it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to