Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/6672#discussion_r33658277
--- Diff:
core/src/test/scala/org/apache/spark/storage/BlockStatusListenerSuite.scala ---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.storage
+
+import org.apache.spark.SparkFunSuite
+import org.apache.spark.scheduler._
+
+class BlockStatusListenerSuite extends SparkFunSuite {
+
+ test("basic functions") {
+ val blockManagerId = BlockManagerId("0", "localhost", 10000)
+ val listener = new BlockStatusListener()
+ listener.onBlockManagerAdded(SparkListenerBlockManagerAdded(0,
blockManagerId, 0))
+ listener.onBlockUpdated(SparkListenerBlockUpdated(
+ BlockUpdatedInfo(
+ blockManagerId,
+ StreamBlockId(0, 100),
+ StorageLevel.MEMORY_AND_DISK,
+ memSize = 100,
+ diskSize = 100,
+ externalBlockStoreSize = 0)))
+ val blocks = listener.allBlocks
+ assert(blocks.size === 1)
--- End diff --
Can you add more comments on what each of these sets of asserts test? Since
it all inside "basic functions" its hard to understand what are actually being
tested. Actually this one unit test " basic functions" is fairly long. If it
doesnt affect efficiency much, I suggest breaking it into multiple unit tests.
TL;DR either add intermediate comments OR break it down into smaller parts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
