Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/888#discussion_r13062258
--- Diff: core/src/main/scala/org/apache/spark/HttpFileServer.scala ---
@@ -59,6 +59,13 @@ private[spark] class HttpFileServer(securityManager:
SecurityManager) extends Lo
}
def addFileToDir(file: File, dir: File) : String = {
--- End diff --
Looks good, but would it make more sense to put this check in
`SparkContext#addFile`? We might make assumptions elsewhere in the code the
user has supplied a file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
