Github user aarondav commented on the pull request:
https://github.com/apache/spark/pull/887#issuecomment-44236266
I agree that this is technically safer, though I believe in neither of
these cases could a partially-constructed object actually be visible.
`onReceiveCallback` appears to be fully immutable and `cachedPeers` is the
result of a future, so it's probably not possible that it's partially
constructed. Thus, I don't think anyone should be running into either of these
race conditions in practice, but this way is still safer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---