Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/4984#discussion_r33705062
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -286,4 +324,40 @@ private[spark] class CoarseMesosSchedulerBackend(
           super.applicationId
         }
     
    +  override def doRequestTotalExecutors(requestedTotal: Int): Boolean = {
    +    // We don't truly know if we can fulfill the full amount of executors
    +    // since at coarse grain it depends on the amount of slaves available.
    +    if (executorLimitOption.map(_ != requestedTotal).getOrElse(true)) {
    +      logInfo("Capping the total amount of executors to " + requestedTotal)
    +    }
    +    executorLimitOption = Option(requestedTotal)
    --- End diff --
    
    this will always return `Some(int)` I think. You can just use `Some` here 
so it's clearer at a glance. Same in L360


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to