Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/6994#discussion_r33714253
--- Diff:
mllib/src/test/scala/org/apache/spark/mllib/stat/HypothesisTestSuite.scala ---
@@ -153,4 +157,63 @@ class HypothesisTestSuite extends SparkFunSuite with
MLlibTestSparkContext {
Statistics.chiSqTest(sc.parallelize(continuousFeature, 2))
}
}
+
+ test("1 sample kolmogorov smirnov test") {
--- End diff --
`kolmogorov smirnov` -> `Kolmogorov-Smirnov`
Could you also add a unit test to compare with R? Here is one example:
https://github.com/apache/spark/blob/master/mllib/src/test/scala/org/apache/spark/ml/classification/LogisticRegressionSuite.scala#L214
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
