Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6750#discussion_r33720404
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala 
---
    @@ -1002,6 +1001,7 @@ class DAGScheduler(
         val stageId = task.stageId
         val taskType = Utils.getFormattedClassName(task)
     
    +    // REVIEWERS: does this need special handling for multiple completions 
of the same task?
    --- End diff --
    
    great, thanks mark.  I'll leave the comment in for now just to get any 
other reviewers to take a look too.  Think this deserve some special handling 
in the test cases?  (and if so, any suggestions / pointers on what to do?)  I'm 
not very familiar w/ the OutputCommitCoordinator so guidance is appreciated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to