Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/4960#discussion_r33732288
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
---
@@ -188,39 +189,33 @@ private[spark] class CoarseMesosSchedulerBackend(
taskIdToSlaveId(taskId) = slaveId
slaveIdsWithExecutors += slaveId
coresByTaskId(taskId) = cpusToUse
- val task = MesosTaskInfo.newBuilder()
+ // Gather cpu resources from the available resources and use
them in the task.
+ val (remainingResources, taskResources) =
+ partitionResources(offer.getResourcesList, "cpus", cpusToUse)
--- End diff --
these are really cpu resources right? Can we be more explicit about the
naming? Also down there we do the same thing for memory. You could rewrite this
so it's more readable:
```
val (cpuResourcesRemaining, cpuResourcesToUse) =
partitionResources(offer.getResourcesList, "cpus", cpusToUse)
val (_, memResourcesToUse) =
partitionResources(offer.getResourcesList, "mem",
MemoryUtils.calculateTotalMemory(sc))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
