Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/6880#issuecomment-117854395
@FlytxtRnD I haven't checked the implementation yet. Some high-level
comments:
1. Please follow the code style guide. I saw wrong indentation, extra
spacing, vertical alignment in your code.
2. Move save/load and the example code to follow-up PRs. Keep this PR small
to accelerate the code review.
3. Check the generated API doc. Usually this is the simplest way to find
public APIs that should be private.
On the algorithm part, could you list a few successful stories about
k-means vs. kp-means? Some benchmark result also helps.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
