GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/7173
[SPARK-7835] Refactor HeartbeatReceiverSuite for coverage + cleanup
The existing test suite has a lot of duplicate code and doesn't even cover
the most fundamental feature of the HeartbeatReceiver, which is expiring hosts
that have not responded in a while.
This introduces manual clocks in `HeartbeatReceiver` and makes it respond
to heartbeats only for registered executors. A few internal messages are moved
to `receiveAndReply` to increase determinism of the tests so we don't have to
rely on flaky constructs like `eventually`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark heartbeat-receiver-tests
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/7173.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7173
----
commit 4a903d6b9c5f13ad8342e2f05b3b21f85e46cef4
Author: Andrew Or <[email protected]>
Date: 2015-07-02T01:43:49Z
Increase HeartReceiverSuite coverage and clean up
Now it covers expiring dead hosts and has much less duplicate code.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
