Github user tarekauel commented on a diff in the pull request:
https://github.com/apache/spark/pull/7178#discussion_r33750813
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -1299,6 +1299,44 @@ object functions {
def rint(columnName: String): Column = rint(Column(columnName))
/**
+ * Shift the the given value numBits left. Returns int for tinyint,
smallint and int and
+ * bigint for bigint a.
+ *
+ * @group math_funcs
+ * @since 1.5.0
+ */
+ def shiftLeft(e: Column, numBits: Integer): Column = ShiftLeft(e.expr,
lit(numBits).expr)
--- End diff --
If your comment is about the `lit(numBits)` , yes it's true. I tried to do
it consistent with other functions (sha2 does it the same way, see
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L1458,
or log
https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/functions.scala#L1161).
Do I get something wrong?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
