Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7181#discussion_r33755269
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/math.scala
---
@@ -303,6 +295,66 @@ case class Hex(child: Expression) extends
UnaryExpression with Serializable {
}
}
+/**
+ * Performs the inverse operation of HEX.
+ * Resulting characters are returned as a byte array.
+ */
+case class Unhex(child: Expression)
+ extends UnaryExpression with AutoCastInputTypes with Serializable {
+
+ override def nullable: Boolean = true
+ override def dataType: DataType = BinaryType
+ override def inputTypes: Seq[DataType] = Seq(BinaryType)
+
+ override def eval(input: InternalRow): Any = {
+ val num = child.eval(input)
+ if (num == null) {
+ null
+ } else {
+ unhex(num.asInstanceOf[UTF8String].getBytes)
+ }
+ }
+
+ // lookup table to translate '0' -> 0 ... 'F'/'f' -> 15
+ private[this] val unhexDigits = {
--- End diff --
how is this less code? It is just a bad idea to create unnecessary state.
Just move both tables into two fields in Hex object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]