Github user chenghao-intel commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6872#discussion_r33774116
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -67,6 +67,24 @@ object functions {
       def column(colName: String): Column = Column(colName)
     
       /**
    +   * Convert a number from one base to another for the specified 
expressions
    +   *
    +   * @group math_funcs
    +   * @since 1.5.0
    +   */
    +  def conv(num: Column, fromBase: Column, toBase: Column): Column =
    +    Conv(num.expr, fromBase.expr, toBase.expr )
    +
    +  /**
    +   * Convert a number from one base to another for the specified 
expressions
    +   *
    +   * @group math_funcs
    +   * @since 1.5.0
    +   */
    +  def conv(num: String, fromBase: String, toBase: String): Column =
    --- End diff --
    
    Probably more user cases of `fromBase` and the `toBase` will be represented 
as the real value, than the column names? What do you think? 
    @rxin we actually have some cases like this, do you think if we need to 
support both constant string values and column names for cases like this? 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to