Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7201#discussion_r33831527
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/stat/StatFunctions.scala 
---
    @@ -110,8 +110,12 @@ private[sql] object StatFunctions extends Logging {
           logWarning("The maximum limit of 1e6 pairs have been collected, 
which may not be all of " +
             "the pairs. Please try reducing the amount of distinct items in 
your columns.")
         }
    +    def cleanElement(element: Any): String = {
    +      if (element == null) "" else element.toString
    --- End diff --
    
    we should probably say "null" rather than empty for null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to