Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7196#discussion_r33837977
  
    --- Diff: 
launcher/src/test/java/org/apache/spark/launcher/SparkSubmitCommandBuilderSuite.java
 ---
    @@ -194,7 +194,7 @@ private void testCmdBuilder(boolean isDriver) throws 
Exception {
             if (isDriver) {
               assertEquals("-XX:MaxPermSize=256m", arg);
             } else {
    -          assertEquals("-XX:MaxPermSize=128m", arg);
    +          assertEquals("-XX:MaxPermSize=256m", arg);
    --- End diff --
    
    I think it literally just says give more perm space for the driver than 
executors. This change is probably OK.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to