Github user ash211 commented on a diff in the pull request:
https://github.com/apache/spark/pull/896#discussion_r13116025
--- Diff: docs/running-on-mesos.md ---
@@ -103,7 +103,7 @@ the `make-distribution.sh` script included in a Spark
source tarball/checkout.
## Using a Mesos Master URL
The Master URLs for Mesos are in the form `mesos://host:5050` for a
single-master Mesos
-cluster, or `zk://host:2181` for a multi-master Mesos cluster using
ZooKeeper.
+cluster, or `mesos://zk://host:2181` for a multi-master Mesos cluster
using ZooKeeper.
--- End diff --
I thought this change was wrong because the `MESOS_REGEX` at
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L1437
is `"""(mesos|zk)://.*""".r` but after reading through the code this change is
actually correct.
I'm not sure that `mesos://zk://host:2181` is a [valid
URL](https://en.wikipedia.org/wiki/Uniform_resource_locator#Syntax) though.
JDBC for example uses `jdbc:postgresql://` like in
`jdbc:postgresql://localhost/test` rather than `jdbc://postgresql://...` Issue
for a later time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
