Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7197#discussion_r33841774
--- Diff:
unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java ---
@@ -25,21 +25,30 @@
public class UTF8StringSuite {
private void checkBasic(String str, int len) throws
UnsupportedEncodingException {
- Assert.assertEquals(UTF8String.fromString(str).length(), len);
-
Assert.assertEquals(UTF8String.fromBytes(str.getBytes("utf8")).length(), len);
+ UTF8String s1 = UTF8String.fromString(str);
+ UTF8String s2 = UTF8String.fromBytes(str.getBytes("utf8"));
+ Assert.assertEquals(s1.length(), len);
+ Assert.assertEquals(s2.length(), len);
- Assert.assertEquals(UTF8String.fromString(str).toString(), str);
-
Assert.assertEquals(UTF8String.fromBytes(str.getBytes("utf8")).toString(), str);
- Assert.assertEquals(UTF8String.fromBytes(str.getBytes("utf8")),
UTF8String.fromString(str));
+ Assert.assertEquals(s1.toString(), str);
+ Assert.assertEquals(s2.toString(), str);
+ Assert.assertEquals(s1, s2);
- Assert.assertEquals(UTF8String.fromString(str).hashCode(),
- UTF8String.fromBytes(str.getBytes("utf8")).hashCode());
+ Assert.assertEquals(s1.hashCode(), s2.hashCode());
+
+ Assert.assertEquals(s1.compare(s2), 0);
+ Assert.assertEquals(s1.compareTo(s2), 0);
+
+ Assert.assertEquals(s1.contains(s2), true);
+ Assert.assertEquals(s2.contains(s1), true);
+ Assert.assertEquals(s1.startsWith(s1), true);
+ Assert.assertEquals(s1.endsWith(s1), true);
}
@Test
public void basicTest() throws UnsupportedEncodingException {
checkBasic("hello", 5);
- checkBasic("ä¸ ç", 3);
+ checkBasic("大 å ä¸ ç", 7);
--- End diff --
We should probably also add a test case for the empty string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
