Github user suyanNone commented on a diff in the pull request:
https://github.com/apache/spark/pull/4055#discussion_r33858523
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -305,7 +305,7 @@ private[spark] class MapOutputTrackerMaster(conf:
SparkConf)
if (mapStatuses.contains(shuffleId)) {
val statuses = mapStatuses(shuffleId)
- if (statuses.nonEmpty) {
+ if (statuses.nonEmpty && statuses.exists(_ != null)) {
--- End diff --
These two correctness occurs while I revert my modify back to verify my
test case will fails. but when I do this, it always encounter some strange
problem.
while we submitMissingTask, we will call `getPreferredLocs` for each task.
and in that, for rdd's each ShuffleDependency, it will call
`mapOutputTracker.getLocationsWithLargestOutputs(`, and in that, it will judge
status.nonEmpty(), so it alway true,
so it will always call `val status = statuses(mapIdx); val blockSize =
status.getSizeForBlock(reducerId)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
