Github user chenghao-intel commented on the pull request:
https://github.com/apache/spark/pull/7157#issuecomment-118340829
Thank you for working on this @cloud-fan.This PR definitely will save the
code, but I have some concerns on the interface updating, not about what you
did in this PR, but in general:
- Currently, too many callback functions need to implement when inherit
from different abstract expression classes, it will be the barrier to who are
new in the expression framework. From the SPI design princple point of view,
we'd better keep the interface the simpler the better.
- Default behavor is ok for most of cases, but there are always exceptional
cases, expression developer needs more freedom.
- It's not a big deal if we leave some duplicated code in expressions, as
each of them are quite independent, that would be more straightforward for
people to read / review it. (we don't want to jump back and forward while
reading the code from web, right?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
