Github user thegiive commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7038#discussion_r33881396
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/JsonProtocol.scala ---
    @@ -76,12 +76,13 @@ private[deploy] object JsonProtocol {
       }
     
       def writeMasterState(obj: MasterStateResponse): JObject = {
    +    val alive_workers = obj.workers.filter(_.isAlive())
    --- End diff --
    
    Hi Andrew
    
    WorkerState is org.apache.spark.deploy.master's private object. 
JsonProtocol cannot resolved WorkerState due to class visibility.This code 
cannot work unless we change WorkerState code. 
    
    I think best way to do that is add a one line method on WorkerInfo 
    
    How do you think? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to