Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/7219#issuecomment-118523169
Hey @andrewor14 - I took a look at this. It seems, to me a bit weird to
have Spark core dependend on Scalatest. This will affect all of our downstream
applications, since they will also inherit the scalatest dependency, and that
seems risky given that it has its own transitive dependencies (most of those
are marked as `optional` - but I have no idea how various build tools handle
optional dependencies). I was wondering abut some alternative solutions such as:
1. Just declare `SparkFunSuite` in each module - this is a bit clunky, but
you could have a large warning in the class file that it's N-way replicated.
It's a very small class so I don't anticipate large modifications in the
future. Then we don't have to reason about any build tool behaviors.
2. Do the suggestion from my email where you disable the dependency reduced
pom, except we only enable it for a certain profile.
I am pretty hesitant to change compile dependencies around in 1.4.1 vs
1.4.0 - since we've typically not done this in a release. I also think it would
be good not to have test dependencies as compile, if we can avoid it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
