Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/7084#issuecomment-118662011
I agree we should add an Estimator version of CountVectorizer which first
fits on the data to build a dictionary. Because of that, maybe we should call
this PR's class CountVectorizerModel, and a later PR can add the
CountVectorizer (which will be the Estimator version).
I'll take a look through the PR now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
