Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7219#discussion_r33901034
  
    --- Diff: pom.xml ---
    @@ -1826,6 +1830,26 @@
           </properties>
         </profile>
     
    +    <profile>
    +      <!--
    +          Use this profile only for making Spark releases. Note that due 
to SPARK-8819,
    +          you must use maven version 3.2.x or before to avoid running into 
MSHADE-148.
    +      -->
    +      <id>release</id>
    --- End diff --
    
    Maven's release plugin already uses a profile called `release-profile` for 
stuff like this. Can we use the same name? it's automatically enabled when 
releasing.
    http://maven.apache.org/maven-release/maven-release-plugin/perform-mojo.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to