Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7214#discussion_r33905094
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
    @@ -1580,22 +1580,37 @@ object functions {
       
//////////////////////////////////////////////////////////////////////////////////////////////
     
       /**
    -   * Computes the length of a given string value
    -   *
    +   * Computes the length of a given string value.
    +   * 
    --- End diff --
    
    A few benefits:
    
    1. We don't need to depend on commons-util. In general it is good to reduce 
external dependency due to dependency conflicts.
    
    2. Our version ideally should work directly against UTF8String, so we don't 
need conversion.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to