Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7219#discussion_r33911870
  
    --- Diff: pom.xml ---
    @@ -1826,6 +1830,26 @@
           </properties>
         </profile>
     
    +    <profile>
    +      <!--
    +          Use this profile only for making Spark releases. Note that due 
to SPARK-8819,
    +          you must use maven version 3.2.x or before to avoid running into 
MSHADE-148.
    +      -->
    +      <id>release-profile</id>
    --- End diff --
    
    @pwendell see my comments. `release-profile` is the standard name of the 
profile triggered by `maven-release-plugin`. I think you're not actually using 
the release plugin to publish (not an issue right now but did it not work? the 
script recreates some of what it does) but still might be clearer to use the 
standard name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to