Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7185#discussion_r33973297
  
    --- Diff: python/pyspark/streaming/dstream.py ---
    @@ -602,13 +602,17 @@ class TransformedDStream(DStream):
         Multiple continuous transformations of DStream can be combined into
         one transformation.
         """
    -    def __init__(self, prev, func):
    +    def __init__(self, prev, func, transformFunc=None):
    --- End diff --
    
    Why is this a parameter in the DStream constructor? Seems pretty weird to 
suddenly have one of the operations be randomly configurable through a field in 
the constructor. Why not override it in a subclass?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to