Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7099#discussion_r33986921
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
    @@ -212,12 +226,110 @@ class LinearRegressionModel private[ml] (
       extends RegressionModel[Vector, LinearRegressionModel]
       with LinearRegressionParams {
     
    +  @transient private var trainingResults: 
Option[LinearRegressionTrainingResults] = None
    +
    +  /**
    +   * Gets results (e.g. residuals, mse, r^2) of model on training set. 
This method should only
    +   * be called on the driver (it is not available on workers).
    +   */
    +  def getTrainingResults: Option[LinearRegressionTrainingResults] = 
trainingResults
    --- End diff --
    
    Option isn't very Java-friendly, so providing ```summary``` and 
```hasSummary``` might be best.  You could keep ```getSummary``` as the Scala 
version which returns an Option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to